Thread (3 messages) flat view 3 messages, 3 authors, 2019-10-24

Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'

From: Chris Chiu <hidden>
Date: 2019-10-23 10:11:07
Also in: linux-wireless, lkml

On Wed, Oct 23, 2019 at 3:54 PM YueHaibing [off-list ref] wrote:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6:
 warning: variable rate_mask set but not used [-Wunused-but-set-variable]

It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve
TX performance of RTL8723BU on rtl8xxxu driver")

Signed-off-by: YueHaibing <redacted>
---
Singed-off-by: Chris Chiu [off-list ref]
quoted hunk ↗ jump to hunk
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 1e3b716..3843d7a 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -4481,11 +4481,6 @@ static u16
 rtl8xxxu_wireless_mode(struct ieee80211_hw *hw, struct ieee80211_sta *sta)
 {
        u16 network_type = WIRELESS_MODE_UNKNOWN;
-       u32 rate_mask;
-
-       rate_mask = (sta->supp_rates[0] & 0xfff) |
-                   (sta->ht_cap.mcs.rx_mask[0] << 12) |
-                   (sta->ht_cap.mcs.rx_mask[0] << 20);

        if (hw->conf.chandef.chan->band == NL80211_BAND_5GHZ) {
                if (sta->vht_cap.vht_supported)
--
2.7.4
Thanks for pointing that out.

Chris
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help