Re: [PATCH v3 1/5] net: ag71xx: port to phylink
From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2019-10-22 05:12:31
Also in:
linux-devicetree, linux-mips, lkml
On 22.10.19 00:21, Russell King - ARM Linux admin wrote:
On Mon, Oct 21, 2019 at 07:38:07AM +0200, Oleksij Rempel wrote:quoted
+static void ag71xx_mac_validate(struct phylink_config *config, + unsigned long *supported, + struct phylink_link_state *state) { - struct ag71xx *ag = netdev_priv(ndev); + __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, }; + + if (state->interface != PHY_INTERFACE_MODE_NA && + state->interface != PHY_INTERFACE_MODE_GMII && + state->interface != PHY_INTERFACE_MODE_MII) { + bitmap_zero(supported, __ETHTOOL_LINK_MODE_MASK_NBITS); + return; + } + + phylink_set(mask, MII); + + /* flow control is not supported */ + + phylink_set(mask, 10baseT_Half); + phylink_set(mask, 10baseT_Full); + phylink_set(mask, 100baseT_Half); + phylink_set(mask, 100baseT_Full); - ag71xx_link_adjust(ag, true); + if (state->interface == PHY_INTERFACE_MODE_NA && + state->interface == PHY_INTERFACE_MODE_GMII) {This is always false.
... I shame to myself :(
Apart from that, from just reading the patch I have no further concerns.
ok. thx! Kind regards, Oleksij Rempel -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |