Thread (10 messages) 10 messages, 3 authors, 2019-10-11

Re: [PATCH v9 5/5] MIPS: SGI-IP27: Enable ethernet phy on second Origin 200 module

From: Thomas Bogendoerfer <hidden>
Date: 2019-10-11 09:28:09
Also in: linux-doc, linux-mips, linux-rtc, linux-serial, lkml

On Thu, 10 Oct 2019 19:37:15 +0300
Sergei Shtylyov [off-list ref] wrote:
On 10/10/2019 05:59 PM, Thomas Bogendoerfer wrote:
quoted
+	/* enable ethernet PHY on IP29 systemboard */
+	pci_read_config_dword(dev, PCI_SUBSYSTEM_VENDOR_ID, &sid);
+	if (sid == ((PCI_VENDOR_ID_SGI << 16) | IOC3_SUBSYS_IP29_SYSBOARD))
   I thought PCI was little endian, thuis vendor ID at offset 0 and device ID
at offset 2?
you are right. I already messed it up in pci-xtalk-bridge.c. As this is just a
fake sub device id, there is no harm, but I'll fix it.

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 247165 (AG München)
Geschäftsführer: Felix Imendörffer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help