Re: [PATCH net,v2 1/2] net: ethernet: mediatek: Fix MT7629 missing GMII mode support
From: Jakub Kicinski <hidden>
Date: 2019-10-08 23:06:59
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, lkml
On Mon, 7 Oct 2019 15:08:43 +0800, MarkLee wrote:
Add missing configuration for mt7629 gmii mode support
Fixes: 7e538372694b ("net: ethernet: mediatek: Re-add support SGMII")Thank you for adding the Fixes tag. It seem, however, that the patch in question did not change the ge_mode setting. Is it because GMII now makes a call to mtk_gmac_gephy_path_setup() that the different setting is required? The Fixes tag should point to the commit which introduced the wrong behaviour, it may be the initial commit of the driver if the behaviour was always there. Could you add more information to the patch description and perhaps update Fixes tag if 7e538372694b didn't introduce the problem?