Re: [PATCH v2] ar5523: check NULL before memcpy() in ar5523_cmd()
From: Kalle Valo <hidden>
Date: 2019-10-02 17:22:11
Also in:
linux-wireless, lkml, stable
From: Kalle Valo <hidden>
Date: 2019-10-02 17:22:11
Also in:
linux-wireless, lkml, stable
Denis Efremov [off-list ref] wrote:
memcpy() call with "idata == NULL && ilen == 0" results in undefined behavior in ar5523_cmd(). For example, NULL is passed in callchain "ar5523_stat_work() -> ar5523_cmd_write() -> ar5523_cmd()". This patch adds ilen check before memcpy() call in ar5523_cmd() to prevent an undefined behavior. Cc: Pontus Fuchs <redacted> Cc: Kalle Valo <redacted> Cc: "David S. Miller" <davem@davemloft.net> Cc: David Laight <redacted> Cc: stable@vger.kernel.org Signed-off-by: Denis Efremov <efremov@linux.com> Signed-off-by: Kalle Valo <redacted>
Patch applied to ath-next branch of ath.git, thanks. 315cee426f87 ar5523: check NULL before memcpy() in ar5523_cmd() -- https://patchwork.kernel.org/patch/11167401/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches