Re: [PATCH v1 3/5] staging: fieldbus core: add support for device configuration
From: Sven Van Asbroeck <hidden>
Date: 2019-10-02 15:08:01
Also in:
lkml
From: Sven Van Asbroeck <hidden>
Date: 2019-10-02 15:08:01
Also in:
lkml
On Mon, Sep 30, 2019 at 10:09 AM Greg KH [off-list ref] wrote:
Why is a new way of doing configuration needed here? What does this provide that the current code doesn't already do?
The fieldbus core doesn't have a configuration mechanism yet. This patch adds one. I deliberately omitted configuration when the core was added - I wanted to keep complexity to a minimum. I'm sorry I didn't make this clearer. As a result, the current core can only work with cards that either don't require any config, or get it straight from the network/PLC. Profinet is a good example of this. Most cards do require config however. So does the hms flnet card, which I tried to add in the patchset.
And have you looked at the recent configfs fixes to make sure this code still works with them? I can't test this so rebasing this on 5.4-rc1 would be good for you to do first.
Thanks for the heads-up! I will test that out.