Re: [PATCH v3] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Date: 2019-10-02 11:00:42
Also in:
intel-gfx, linux-usb, lkml
On 02/10/2019 12.11, Jani Nikula wrote:
On Tue, 01 Oct 2019, Jani Nikula [off-list ref] wrote:quoted
While the main goal here is to abstract recurring patterns, and slightly clean up the code base by not open coding the ternary operators, there are also some space savings to be had via better string constant pooling.Make that """ While the main goal here is to abstract recurring patterns, and slightly clean up the code base by not open coding the ternary operators, using functions to access the strings also makes it easier to seek different implementation options for potential space savings on string constants in the future. """ to be more explicit that this change does not directly translate to any space savings. Rasmus, okay with that?
It's rather fluffy, but it doesn't make unfounded claims about space savings, so in that regard I'm fine with it. [It's probably just my lack of imagination, but I still fail to see how one could ever achieve better than the linker creating just 1 vmlinux-wide instance of "enabled", which I believe happens regardless of whether one uses these helpers or not.] Rasmus