Thread (19 messages) 19 messages, 5 authors, 2019-11-03

Re: [PATCH net-next v4 6/6] sfc: add XDP counters to ethtool stats

From: David Ahern <hidden>
Date: 2019-10-31 20:20:48

On 10/31/19 2:13 PM, Jesper Dangaard Brouer wrote:
On Thu, 31 Oct 2019 10:24:23 +0000
Charles McLachlan [off-list ref] wrote:
quoted
Count XDP packet drops, error drops, transmissions and redirects and
expose these counters via the ethtool stats command.

Signed-off-by: Charles McLachlan <redacted>
I'm going to ACK this even-though I don't like these driver specific
counters.  Given we have failed to standardize this, I really cannot
complain.  Hopefully we will get this standardized later

Acked-by: Jesper Dangaard Brouer <redacted>

Left code below, if Ahern want to complain ;-)
testing the patches now.

As for the driver specific counters, I have the same opinion. I'd rather
have counters than wait for some alignment.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help