On Wed, Oct 16, 2019 at 6:42 PM David Laight [off-list ref] wrote:

From: David Miller

quoted

Sent: 16 October 2019 01:57
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 14 Oct 2019 14:14:43 +0800

quoted

SCTP-PF was implemented based on a Internet-Draft in 2012:

  https://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05

It's been updated quite a few by rfc7829 in 2016.

This patchset adds the following features:

  1. add SCTP_ADDR_POTENTIALLY_FAILED notification
  2. add pf_expose per netns/sock/asoc
  3. add SCTP_EXPOSE_POTENTIALLY_FAILED_STATE sockopt
  4. add ps_retrans per netns/sock/asoc/transport
     (Primary Path Switchover)
  5. add spt_pathcpthld for SCTP_PEER_ADDR_THLDS sockopt

I would like to see some SCTP expert ACKs here.

I'm only an SCTP user, but I think some of the API changes aren't right.

Hi, David L.

I think you must know quite a few user cases.

Before I repost, can you pls give the exact places where the API
changes may not be right as you've already done in v1 and v2, so
that I can correct them.

Thanks.

I'm not going to try to grok the sctp code - it makes my brain hurt.
(Even though I've written plenty of protocol stack code.)

        David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)