Re: [patch net-next v3 11/15] netdevsim: implement proper devlink reload

On Fri, 4 Oct 2019 08:19:14 +0200, Jiri Pirko wrote:

quoted

quoted

@@ -84,20 +82,10 @@ int nsim_fib_set_max(struct nsim_fib_data *fib_data,
 		entry = &fib_data->ipv6.rules;
 		break;
 	default:
-		return 0;
-	}
-
-	/* not allowing a new max to be less than curren occupancy
-	 * --> no means of evicting entries
-	 */
-	if (val < entry->num) {
-		NL_SET_ERR_MSG_MOD(extack, "New size is less than current occupancy");
-		err = -EINVAL;  

This change in behaviour should perhaps be mentioned in the commit
message. The reload will no longer fail if the resources are
insufficient.   

Reload is going to fail if the resources are insufficient. I have a
selftest for that, please see the last patch.

Oh, because re-registering the fib notifier itself will fail? 
All good then, thanks.

quoted

Since we want to test reload more widely than just for the FIB limits
that does make sense to me. Is that the thinking?