Thread (25 messages) 25 messages, 5 authors, 2019-09-25

Re: [PATCH 5/6] vringh: fix copy direction of vringh_iov_push_kern()

From: Jason Wang <hidden>
Date: 2019-09-25 11:57:35
Also in: dri-devel, intel-gfx, kvm, linux-s390, lkml

On 2019/9/24 下午10:04, Alex Williamson wrote:
On Mon, 23 Sep 2019 12:00:41 -0400
"Michael S. Tsirkin" [off-list ref] wrote:
quoted
On Mon, Sep 23, 2019 at 09:45:59AM -0600, Alex Williamson wrote:
quoted
On Mon, 23 Sep 2019 21:03:30 +0800
Jason Wang [off-list ref] wrote:
  
quoted
We want to copy from iov to buf, so the direction was wrong.

Signed-off-by: Jason Wang <redacted>
---
 drivers/vhost/vringh.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)  
Why is this included in the series?  Seems like an unrelated fix being
held up within a proposal for a new feature.  Thanks,

Alex  
It's better to have it as patch 1/6, but it's a dependency of the
example driver in the series. I can reorder when I apply.
It's a fix, please submit it separately through virtio/vhost channels,
then it will already be in the base kernel we use for the rest of the
series.  The remainder of the series certainly suggests a workflow
through the vfio tree rather than virtio/vhost.  Thanks,

Alex

Ok.

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help