Re: [PATCH] dimlib: make DIMLIB a hidden symbol
From: Jakub Kicinski <hidden>
Date: 2019-09-22 03:07:47
Also in:
lkml
On Fri, 20 Sep 2019 15:31:15 +0200, Uwe Kleine-König wrote:
quoted hunk ↗ jump to hunk
According to Tal Gilboa the only benefit from DIM comes from a driver that uses it. So it doesn't make sense to make this symbol user visible, instead all drivers that use it should select it (as is already the case AFAICT). Signed-off-by: Uwe Kleine-König <redacted> --- lib/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/lib/Kconfig b/lib/Kconfig index cc04124ed8f7..9fe8a21fd183 100644 --- a/lib/Kconfig +++ b/lib/Kconfig@@ -555,8 +555,7 @@ config SIGNATURE Implementation is done using GnuPG MPI library config DIMLIB - bool "DIM library" - default y + bool help Dynamic Interrupt Moderation library. Implements an algorithm for dynamically change CQ moderation values
Hi Uwe! Looks like in the net tree there is a spelling mistake and moderation is spelled "modertion": https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/tree/lib/Kconfig#n562 I'm not seeing any patch to fix that anywhere, is it possible you have some local change in your tree?