Re: [PATCH] net/mlx5: Declare 'rt' as corresponding enum type
From: Saeed Mahameed <hidden>
Date: 2019-09-10 17:59:36
Also in:
linux-rdma, lkml
On Tue, 2019-09-10 at 18:27 +0900, Austin Kim wrote:
When building kernel with clang, we can observe below warning
message:
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1080:9:
warning: implicit conversion from enumeration type 'enum
mlx5_reformat_ctx_type'
to different enumeration type 'enum mlx5dr_action_type' [- Wenum-
conversion]
rt = MLX5_REFORMAT_TYPE_L2_TO_L2_TUNNEL;
~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1082:9:
warning: implicit conversion from enumeration type 'enum
mlx5_reformat_ctx_type'
to different enumeration type 'enum mlx5dr_action_type' [- Wenum-
conversion]
rt = MLX5_REFORMAT_TYPE_L2_TO_L3_TUNNEL;
~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1084:51:
warning: implicit conversion from enumeration type 'enum
mlx5dr_action_type'
to different enumeration type 'enum mlx5_reformat_ctx_type'
[- Wenum-conversion]
ret = mlx5dr_cmd_create_reformat_ctx(dmn->mdev, rt, data_sz,
data,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~
Declare 'rt' as corresponding enum mlx5_reformat_ctx_type type.
Signed-off-by: Austin Kim <redacted>Hi Austin, Thanks for the patch: We already have a similar patch queued for submission. https://patchwork.ozlabs.org/patch/1158175/
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c index a02f87f..7d81a77 100644--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c@@ -1074,7 +1074,7 @@ dr_action_create_reformat_action(structmlx5dr_domain *dmn, case DR_ACTION_TYP_L2_TO_TNL_L2: case DR_ACTION_TYP_L2_TO_TNL_L3: { - enum mlx5dr_action_type rt; + enum mlx5_reformat_ctx_type rt; if (action->action_type == DR_ACTION_TYP_L2_TO_TNL_L2) rt = MLX5_REFORMAT_TYPE_L2_TO_L2_TUNNEL;