Re: [PATCH net-next 1/3] net: dsa: microchip: add KSZ9477 I2C driver

On Fri, Sep 6, 2019 at 4:42 PM Marek Vasut [off-list ref] wrote:

On 9/6/19 11:30 PM, George McCollister wrote:

[...]

quoted

--- /dev/null
+++ b/drivers/net/dsa/microchip/ksz9477_i2c.c

@@ -0,0 +1,100 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Microchip KSZ9477 series register access through I2C
+ *
+ * Copyright (C) 2018-2019 Microchip Technology Inc.

Doesn't the copyright need update ?

I figured it wasn't necessary since you didn't update the copyright in
ksz9477_spi.c when you converted it to use regmap and made other
changes.
You're suggesting I add my copyright below this one, correct?

quoted

+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/regmap.h>
+#include <linux/i2c.h>

Please keep the headers sorted.

Ack. Moving linux/i2c.h before linux/kernel.h in v2.

quoted

+#include "ksz_common.h"
+
+KSZ_REGMAP_TABLE(ksz9477, not_used, 16, 0, 0);
+

The rest looks good.

[...]

--
Best regards,
Marek Vasut