Re: [PATCH 2/2] vhost: re-introducing metadata acceleration through kernel virtual address

On 2019/9/6 上午11:21, Hillf Danton wrote:

On Thu,  5 Sep 2019 20:27:36 +0800 From:   Jason Wang [off-list ref]

quoted

+static void vhost_set_map_dirty(struct vhost_virtqueue *vq,
+				struct vhost_map *map, int index)
+{
+	struct vhost_uaddr *uaddr = &vq->uaddrs[index];
+	int i;
+
+	if (uaddr->write) {
+		for (i = 0; i < map->npages; i++)
+			set_page_dirty(map->pages[i]);
+	}

Not sure need to set page dirty under page lock.

Just to make sure I understand the issue. Do you mean there's no need 
for set_page_dirty() here? If yes, is there any other function that 
already did this?

Thanks