Thread (3 messages) 3 messages, 3 authors, 2019-09-01

Re: [PATCH] net: seeq: Fix the function used to release some memory in an error handling path

From: David Miller <hidden>
Date: 2019-09-01 19:11:14
Also in: kernel-janitors, lkml

From: Christophe JAILLET <redacted>
Date: Sat, 31 Aug 2019 09:17:51 +0200
In commit 99cd149efe82 ("sgiseeq: replace use of dma_cache_wback_inv"),
a call to 'get_zeroed_page()' has been turned into a call to
'dma_alloc_coherent()'. Only the remove function has been updated to turn
the corresponding 'free_page()' into 'dma_free_attrs()'.
The error hndling path of the probe function has not been updated.

Fix it now.

Rename the corresponding label to something more in line.

Fixes: 99cd149efe82 ("sgiseeq: replace use of dma_cache_wback_inv")
Signed-off-by: Christophe JAILLET <redacted>
Applied.
If 'dma_alloc_coherent()' fails, maybe the message in printk could be
improved. The comment above may also not be relevant.
Memory allocation failures already give a stack backtrack down deep in the
memory allocators, therefore printing messages at allocation call sites
are veboten.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help