Thread (5 messages) 5 messages, 2 authors, 2019-09-28

Re: [PATCH] net: dsa: rtl8366: Check VLAN ID and not ports

From: Linus Walleij <hidden>
Date: 2019-09-28 20:43:55

On Sat, Sep 28, 2019 at 10:36 PM Florian Fainelli [off-list ref] wrote:
Do we need to duplicate the same is_vlan_valid() check in both the
vlan_prepare and vlan_add callbacks?
I'm unsure of the semantics of these calls, the check was in the
OpenWrt driver that I started from.

Is it guaranteed that .vlan_prepare() and .vlan_add() are
always called in succession? Then .vlan_prepare() should
be enough.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help