On Fri, Sep 27, 2019 at 02:28:20PM +0000, Saleem, Shiraz wrote:

quoted

Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions

On Thu, Sep 26, 2019 at 07:49:33PM +0000, Saleem, Shiraz wrote:

quoted

quoted

Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility
definitions

On Thu, Sep 26, 2019 at 09:45:14AM -0700, Jeff Kirsher wrote:

quoted

From: Mustafa Ismail <redacted>

Add miscellaneous utility functions and headers.

Signed-off-by: Mustafa Ismail <redacted>
Signed-off-by: Shiraz Saleem <redacted>
---
 drivers/infiniband/hw/irdma/osdep.h  |  108 ++
 drivers/infiniband/hw/irdma/protos.h |   96 ++
 drivers/infiniband/hw/irdma/status.h |   70 +
 drivers/infiniband/hw/irdma/utils.c  | 2333
++++++++++++++++++++++++++
 4 files changed, 2607 insertions(+)  create mode 100644
drivers/infiniband/hw/irdma/osdep.h
 create mode 100644 drivers/infiniband/hw/irdma/protos.h
 create mode 100644 drivers/infiniband/hw/irdma/status.h
 create mode 100644 drivers/infiniband/hw/irdma/utils.c

diff --git a/drivers/infiniband/hw/irdma/osdep.h

b/drivers/infiniband/hw/irdma/osdep.h
new file mode 100644
index 000000000000..5885b6fa413d

--- /dev/null
+++ b/drivers/infiniband/hw/irdma/osdep.h

@@ -0,0 +1,108 @@
+/* SPDX-License-Identifier: GPL-2.0 or Linux-OpenIB */
+/* Copyright (c) 2019, Intel Corporation. */
+
+#ifndef IRDMA_OSDEP_H
+#define IRDMA_OSDEP_H
+
+#include <linux/version.h>
+#include <linux/kernel.h>
+#include <linux/vmalloc.h>
+#include <linux/string.h>
+#include <linux/bitops.h>
+#include <linux/pci.h>
+#include <net/tcp.h>
+#include <crypto/hash.h>
+/* get readq/writeq support for 32 bit kernels, use the low-first
+version */ #include <linux/io-64-nonatomic-lo-hi.h>
+
+#define MAKEMASK(m, s) ((m) << (s))

It is a little bit over-macro.

Why is this a problem?
We are not translating any basic kernel construct here.

See BIT() definition.

OK. And?

And you just re-created GENMASK().  Please use in-kernel definitions
instead of creating your own.

thanks,

greg k-h