Re: [PATCH net v2] net/sched: cbs: Fix not adding cbs instance to list

Hi,

Cong Wang [off-list ref] writes:

On Mon, Sep 23, 2019 at 5:14 PM Vinicius Costa Gomes
[off-list ref] wrote:

quoted

@@ -417,12 +421,6 @@ static int cbs_init(struct Qdisc *sch, struct nlattr *opt,
        if (err)
                return err;

-       if (!q->offload) {
-               spin_lock(&cbs_list_lock);
-               list_add(&q->cbs_list, &cbs_list);
-               spin_unlock(&cbs_list_lock);
-       }
-
        return 0;

These two return's now can be folded into one, right?

Yeah, good catch. Will fix.


Cheers,
--
Vinicius