Re: iproute2: tc: potential buffer overflow
From: <hidden>
Date: 2019-09-07 13:57:52
Attachments
- iproute2-overflow-fix.patch [text/x-diff] 1075 bytes · preview
From: <hidden>
Date: 2019-09-07 13:57:52
The updated patch is in the attachment. ---------- Původní e-mail ---------- Od: Stephen Hemminger [off-list ref] Komu: tomaspaukrt@email.cz Datum: 31. 8. 2019 17:38:01 Předmět: Re: iproute2: tc: potential buffer overflow On Sat, 31 Aug 2019 15:13:27 +0200 (CEST) [off-list ref] wrote:
Hi, there are two potentially dangerous calls of strcpy function in the program "tc". In the attachment is a patch that fixes this issue. Tomas
This looks correct. Please fix with strlcpy() instead; that is clearer. Plus you can use XT_EXTENSION_MAX_NAMELEN here (optional).