Hi Prashant:

We will try to implement your requests.
Based on our experience, upstream reviewer often reject our modification if they have any concern.
Do you think you can talk to them about this idea and see if they will accept it or not?
Or if you can help on this after we submit it?

Also, Hayes is now updating our current upstream driver and it goes back and forth for a while.
So we will need some time to finish it and the target schedule to have your request done is in the end of this month.

Thank you very much.

Best Regards,
Bambi Yeh

-----Original Message-----
From: Hayes Wang <redacted> 
Sent: Monday, September 2, 2019 2:31 PM
To: Amber Chen <redacted>; Prashant Malani <redacted>
Cc: David Miller <davem@davemloft.net>; netdev@vger.kernel.org; Bambi Yeh <redacted>; Ryankao <redacted>; Jackc <redacted>; Albertk <redacted>; marcochen@google.com; nic_swsd <redacted>; Grant Grundler <redacted>
Subject: RE: Proposal: r8152 firmware patching framework

Prashant Malani [off-list ref] 

quoted

(Adding a few more Realtek folks)

Friendly ping. Any thoughts / feedback, Realtek folks (and others) ?

quoted

On Thu, Aug 29, 2019 at 11:40 AM Prashant Malani

[off-list ref] wrote:

quoted

quoted

Hi,

The r8152 driver source code distributed by Realtek (on
www.realtek.com) contains firmware patches. This involves binary 
byte-arrays being written byte/word-wise to the hardware memory
Example: grundler@chromium.org (cc-ed) has an experimental patch

which

quoted

quoted

includes the firmware patching code which was distributed with the 
Realtek source :

https://chromium-review.googlesource.com/c/chromiumos/third_party/kern
el
/+/1417953

quoted

quoted

It would be nice to have a way to incorporate these firmware fixes 
into the upstream code. Since having indecipherable byte-arrays is 
not possible upstream, I propose the following:
- We use the assistance of Realtek to come up with a format which 
the firmware patch files can follow (this can be documented in the 
comments).
      - A real simple format could look like this:
              +

<section1><size_in_bytes><address1><data1><address2><data2>...<address
N

quoted

<dataN><section2>...

quoted

               + The driver would be able to understand how to 
parse each section (e.g is each data entry a byte or a word?)

- We use request_firmware() to load the firmware, parse it and 
write the data to the relevant registers.

I plan to finish the patches which I am going to submit, first. Then, I could focus on this. However, I don't think I would start this quickly. There are many preparations and they would take me a lot of time.

Best Regards,
Hayes