Thread (7 messages) 7 messages, 5 authors, 2019-08-20

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

From: Björn Töpel <hidden>
Date: 2019-08-20 07:28:34
Also in: bpf, kernel-janitors

On 2019-08-20 03:36, YueHaibing wrote:
quoted hunk ↗ jump to hunk
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Signed-off-by: YueHaibing <redacted>
---
  kernel/bpf/xskmap.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/xskmap.c b/kernel/bpf/xskmap.c
index 4cc28e226398..942c662e2eed 100644
--- a/kernel/bpf/xskmap.c
+++ b/kernel/bpf/xskmap.c
@@ -21,7 +21,7 @@ int xsk_map_inc(struct xsk_map *map)
  	struct bpf_map *m = &map->map;
  
  	m = bpf_map_inc(m, false);
-	return IS_ERR(m) ? PTR_ERR(m) : 0;
+	return PTR_ERR_OR_ZERO(m);
  }
  
  void xsk_map_put(struct xsk_map *map)
Acked-by: Björn Töpel <redacted>

Thanks for the patch!

For future patches: Prefix AF_XDP socket work with "xsk:" and use "PATCH
bpf-next" to let the developers know what tree you're aiming for.



Cheers!
Björn

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help