Thread (3 messages) 3 messages, 3 authors, 2019-08-30

Re: [PATCH][V2] wimax/i2400m: remove debug containing bogus calculation of index

From: Dan Carpenter <hidden>
Date: 2019-08-30 11:40:51
Also in: kernel-janitors, lkml

On Fri, Aug 30, 2019 at 10:07:11AM +0100, Colin King wrote:
From: Colin Ian King <redacted>

The subtraction of the two pointers is automatically scaled by the
size of the size of the object the pointers point to, so the division
by sizeof(*i2400m->barker) is incorrect.  This has been broken since
day one of the driver and is only debug, so remove the debug completely.

Also move && in condition to clean up a checkpatch warning.

Addresses-Coverity: ("Extra sizeof expression")
Signed-off-by: Colin Ian King <redacted>
Reviewed-by: Dan Carpenter <redacted>

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help