Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
From: walter harms <hidden>
Date: 2019-08-27 07:24:57
Also in:
kernel-janitors, linux-rdma, lkml
Am 27.08.2019 05:12, schrieb Mao Wenan:
quoted hunk ↗ jump to hunk
When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors are found: drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_enable': en_main.c:(.text+0xb649): undefined reference to `mlx5e_hv_vhca_stats_create' drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_disable': en_main.c:(.text+0xb8c4): undefined reference to `mlx5e_hv_vhca_stats_destroy' This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by 'commit 348dd93e40c1 ("PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface"), Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE. Fixes: cef35af34d6d ("net/mlx5e: Add mlx5e HV VHCA stats agent") Signed-off-by: Mao Wenan <redacted> --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig index 37fef8c..a6a70ce 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig@@ -35,6 +35,7 @@ config MLX5_CORE_EN depends on IPV6=y || IPV6=n || MLX5_CORE=m
OT but ... is that IPV6 needed at all ? can there be something else that yes or no ? re, wh
select PAGE_POOL select DIMLIB + imply PCI_HYPERV_INTERFACE default n ---help--- Ethernet support in Mellanox Technologies ConnectX-4 NIC.