Re: [PATCH net-next 2/3] net: dsa: mv88e6xxx: extend PTP gettime function to read system clock

On Mon, Aug 19, 2019 at 07:14:25PM +0200, Hubert Feurstein wrote:

Hi Andrew,

Am Mo., 19. Aug. 2019 um 15:27 Uhr schrieb Andrew Lunn [off-list ref]:

quoted

quoted

@@ -45,7 +45,8 @@ static int mv88e6xxx_smi_direct_write(struct mv88e6xxx_chip *chip,
 {
      int ret;

-     ret = mdiobus_write_nested(chip->bus, dev, reg, data);
+     ret = mdiobus_write_sts_nested(chip->bus, dev, reg, data,
+                                    chip->ptp_sts);
      if (ret < 0)
              return ret;

Please also make a similar change to mv88e6xxx_smi_indirect_write().
The last write in that function should be timestamped.

Since it is already the last write it should be already ok (The
mv88e6xxx_smi_indirect_write
calls the mv88e6xxx_smi_direct_write which initiates the timestamping).

Hi Hubert

But you are also time stamping the first write as well. And it seems
like it is not completely for free. So it would be nice to limit it to
the write which actually matters.

    Andrew