Thread (28 messages) 28 messages, 9 authors, 2019-08-21

Re: [PATCH v4 7/9] mfd: ioc3: Add driver for SGI IOC3 chip

From: Jakub Kicinski <hidden>
Date: 2019-08-12 19:52:15
Also in: linux-input, linux-mips, linux-rtc, linux-serial, lkml

On Sun, 11 Aug 2019 09:32:12 +0200, Thomas Bogendoerfer wrote:
quoted
Also please don't use stdint types in the kernel, please try checkpatch
to catch coding style issues.  
my patch already reduces them and checkpatch only warns about usage of printk
for the network part. Changing that to dev_warn/dev_err in the mfd patch didn't
seem the right thing to do. As I'm splitting the conversion patch into a few
steps I could also replace the printks.
Thanks for looking into it. I was referring to the use of uint32_t
instead of u32. Perhaps checkpatch has to be motivated with the --strict
option to point those out?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help