RE: [PATCH net] hv_netvsc: Fix a warning of suspicious RCU usage
From: Dexuan Cui <decui@microsoft.com>
Date: 2019-08-07 06:56:40
Also in:
linux-hyperv, lkml
From: Dexuan Cui <decui@microsoft.com>
Date: 2019-08-07 06:56:40
Also in:
linux-hyperv, lkml
From: Jakub Kicinski <redacted> Sent: Tuesday, August 6, 2019 12:13 PM To: Dexuan Cui <decui@microsoft.com> On Tue, 6 Aug 2019 05:17:44 +0000, Dexuan Cui wrote:quoted
This fixes a warning of "suspicious rcu_dereference_check() usage" when nload runs. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Signed-off-by: Dexuan Cui <decui@microsoft.com>Minor change in behaviour would perhaps be worth acknowledging in the commit message (since you check ndev for NULL later now), and a Fixes tag would be good. But the looks pretty straightforward and correct!
Hi,
Yeah, it looks the minor behavior change doesn't matter, because IMO the
'nvdev' can only be NULL when the NIC is being removed, or the MTU is
being changed, etc.
The Fixes tag is:
Fixes: 776e726bfb34 ("netvsc: fix RCU warning in get_stats")
If I should send a v2, please let me know.
Thanks,
-- Dexuan