Re: [PATCH net v2] mvpp2: fix panic on module removal

From
David Miller <davem@davemloft.net>
Date
2019-08-01 17:08:51
Also in
lkml
Reply to
Matteo Croce, 2019-08-01
From: Matteo Croce <redacted>
Date: Thu,  1 Aug 2019 14:13:30 +0200
mvpp2 uses a delayed workqueue to gather traffic statistics.
On module removal the workqueue can be destroyed before calling
cancel_delayed_work_sync() on its works.
Fix it by moving the destroy_workqueue() call after mvpp2_port_remove().
Also remove an unneeded call to flush_workqueue()
 ...
Fixes: 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Matteo Croce <redacted>
Applied and queued up for -stable, thanks.
Thread (3 messages) 3 messages, 3 authors, last reply 2019-08-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help