Thread (52 messages) 52 messages, 7 authors, 2019-08-30

Re: [PATCH v3 38/41] powerpc: convert put_page() to put_user_page*()

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2019-08-09 12:20:58
Also in: amd-gfx, ceph-devel, dri-devel, intel-gfx, kvm, linux-arm-kernel, linux-block, linux-crypto, linux-fbdev, linux-fsdevel, linux-media, linux-mm, linux-nfs, linux-rdma, linux-xfs, linuxppc-dev, lkml, sparclinux, xen-devel

John Hubbard [off-list ref] writes:
On 8/7/19 10:42 PM, Michael Ellerman wrote:
quoted
Hi John,

john.hubbard@gmail.com writes:
quoted
diff --git a/arch/powerpc/mm/book3s64/iommu_api.c b/arch/powerpc/mm/book3s64/iommu_api.c
index b056cae3388b..e126193ba295 100644
--- a/arch/powerpc/mm/book3s64/iommu_api.c
+++ b/arch/powerpc/mm/book3s64/iommu_api.c
@@ -203,6 +202,7 @@ static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem)
 {
 	long i;
 	struct page *page = NULL;
+	bool dirty = false;
I don't think you need that initialisation do you?
Nope, it can go. Fixed locally, thanks.
Thanks.
Did you get a chance to look at enough of the other bits to feel comfortable 
with the patch, overall?
Mostly :) It's not really my area, but all the conversions looked
correct to me as best as I could tell.

So I'm fine for it to go in as part of the series:

Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help