Re: [PATCH net-next 0/3] dpaa2-eth: Add new statistics counters
From: Jakub Kicinski <hidden>
Date: 2019-08-31 06:12:46
From: Jakub Kicinski <hidden>
Date: 2019-08-31 06:12:46
On Fri, 30 Aug 2019 13:20:40 +0300, Ioana Radulescu wrote:
Recent firmware versions offer access to more DPNI statistics counters. Add the relevant ones to ethtool interface stats. Also we can now make use of a new counter for in flight egress frames to avoid sleeping an arbitrary amount of time in the ndo_stop routine.
A little messy there in the comment of patch 2, and IMHO if you're expecting particular errors to be ignored it's better to write: if (err == -EOPNOTSUPP) /* still fine*/; else if (err) /* real err */ than assume any error is for unsupported and add a extra comment explaining that things may be not supported. Series LGTM tho.