Thread (6 messages) 6 messages, 2 authors, 2019-08-30

Re: [PATCH 1/3] samples: pktgen: make variable consistent with option

From: Jesper Dangaard Brouer <hidden>
Date: 2019-08-30 12:57:38

On Thu, 29 Aug 2019 05:42:41 +0900
"Daniel T. Lee" [off-list ref] wrote:
This commit changes variable names that can cause confusion.

For example, variable DST_MIN is quite confusing since the
keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl.

On the following commit, 'dst_min' will be used to set destination IP,
and the existing variable name DST_MIN should be changed.

Variable names are matched to the exact keyword used with pg_ctrl.

Signed-off-by: Daniel T. Lee <redacted>
Acked-by: Jesper Dangaard Brouer <redacted>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help