Re: [PATCH net-next v5 3/6] net: dsa: mv88e6xxx: create serdes_get_lane chip operation
From: Vivien Didelot <hidden>
Date: 2019-08-26 22:17:25
Hi Marek, On Mon, 26 Aug 2019 23:31:52 +0200, Marek Behún [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -635,10 +660,10 @@ static irqreturn_t mv88e6390_serdes_thread_fn(int irq, void *dev_id) irqreturn_t ret = IRQ_NONE; u8 cmode = port->cmode; u16 status; - int lane; int err; + u8 lane; - lane = mv88e6390x_serdes_get_lane(chip, port->port); + mv88e6xxx_serdes_get_lane(chip, port->port, &lane);
I don't like when errors aren't always checked, but the code was already like this, so this can be addressed in a follow-up patch: Reviewed-by: Vivien Didelot <redacted> Thanks, Vivien