Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames
From: Jakub Kicinski <hidden>
Date: 2019-08-26 16:56:11
From: Jakub Kicinski <hidden>
Date: 2019-08-26 16:56:11
On Mon, 26 Aug 2019 18:09:16 +0200, Jiri Pirko wrote:
DaveA, Roopa. Do you insist on doing add/remove of altnames in the existing setlist command using embedded message op attrs? I'm asking because after some time thinking about it, it still feels wrong to me :/ If this would be a generic netlink api, we would just add another couple of commands. What is so different we can't add commands here? It is also much simpler code. Easy error handling, no need for rollback, no possibly inconsistent state, etc.
+1 the separate op feels like a better uapi to me as well. Perhaps we could redo the iproute2 command line interface to make the name the primary object? Would that address your concern Dave and Roopa?