Re: [PATCH net-next 01/10] net: dsa: mv88e6xxx: support 2500base-x in SGMII IRQ handler

On Wed, 21 Aug 2019 20:25:42 -0700 (PDT)
David Miller [off-list ref] wrote:

From: Marek Behún <redacted>
Date: Thu, 22 Aug 2019 01:27:15 +0200

quoted

int port, int lane) {
 	struct dsa_switch *ds = chip->ds;
+	u8 cmode = chip->ports[port].cmode;
 	int duplex = DUPLEX_UNKNOWN;
 	int speed = SPEED_UNKNOWN;
 	int link, err;
+	phy_interface_t mode;
 	u16 status;  

Please retain the reverse christmas tree ordering of local variables
here.

Thank you.

:DDDDDDDDDDDDDDDDDD
Okay, I shall do so in next version.