Re: [PATCH v2 net] gve: Copy and paste bug in gve_get_stats()
From: Catherine Sullivan <hidden>
Date: 2019-08-21 17:21:04
Also in:
kernel-janitors
On Tue, Aug 20, 2019 at 2:11 AM Dan Carpenter [off-list ref] wrote:
quoted hunk ↗ jump to hunk
There is a copy and paste error so we have "rx" where "tx" was intended in the priv->tx[] array. Fixes: f5cedc84a30d ("gve: Add transmit and receive support") Signed-off-by: Dan Carpenter <redacted> --- v2: fix a typo in the subject: buy -> bug (Thanks Walter Harms) drivers/net/ethernet/google/gve/gve_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c index 497298752381..aca95f64bde8 100644 --- a/drivers/net/ethernet/google/gve/gve_main.c +++ b/drivers/net/ethernet/google/gve/gve_main.c@@ -50,7 +50,7 @@ static void gve_get_stats(struct net_device *dev, struct rtnl_link_stats64 *s) u64_stats_fetch_begin(&priv->tx[ring].statss); s->tx_packets += priv->tx[ring].pkt_done; s->tx_bytes += priv->tx[ring].bytes_done; - } while (u64_stats_fetch_retry(&priv->rx[ring].statss, + } while (u64_stats_fetch_retry(&priv->tx[ring].statss, start)); } } --2.20.1
Thanks! Reviewed-by: Catherine Sullivan <redacted>