Re: [PATCH net-next 3/6] net: dsa: Delete the VID from the upstream port as well
From: Vivien Didelot <hidden>
Date: 2019-08-20 17:52:17
From: Vivien Didelot <hidden>
Date: 2019-08-20 17:52:17
Hi Vladimir, On Tue, 20 Aug 2019 12:54:44 +0300, Vladimir Oltean [off-list ref] wrote:
I can agree that this isn't one of my brightest moments. But at least we get to see Cunningham's law in action :) When dsa_8021q is cleaning up the switch's VLAN table for the bridge to use it, it is good to really clean it up, i.e. not leave any VLAN installed on the upstream ports. But I think this is just an academical concern at this point. In vlan_filtering mode, the CPU port will accept VLAN frames with the dsa_8021q ID's, but they will eventually get dropped due to no destination. The real breaker is the pvid change. If something like patch 4/6 gets accepted I will drop this one.
I wish Ward had mentioned to submit such academical concern as RFC :) Please submit smaller series, targeting a single functional problem each, with clear and detailed messages. Thanks, Vivien