Mon, Aug 05, 2019 at 04:51:22PM CEST, dsahern@gmail.com wrote:

On 8/5/19 8:49 AM, Jiri Pirko wrote:

quoted

quoted

Your commit 5fc494225c1eb81309cc4c91f183cd30e4edb674 changed that from a
per-namepace accounting to all namespaces managed by a single devlink
instance in init_net - which is completely wrong.

No. Not "all namespaces". Only the one where the devlink is. And that is
always init_net, until this patchset.

Jiri: your change to fib.c does not take into account namespace when
doing rules and routes accounting. you broke it. fix it.

What do you mean by "account namespace"? It's a device resource, why to
tight it with namespace? What if you have 2 netdevsim-devlink instances
in one namespace? Why the setting should be per-namespace?