[PATCH net] ibmveth: use net_err_ratelimited when set_multicast_list
From: Hangbin Liu <hidden>
Date: 2019-08-01 09:04:04
Subsystem:
ibm power virtual ethernet device driver, linux for powerpc (32-bit and 64-bit), networking drivers, the rest · Maintainers:
Nick Child, Madhavan Srinivasan, Michael Ellerman, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
When setting lots of multicast list on ibmveth, e.g. add 3000 membership on a multicast group, the following error message flushes our log file 8507 [ 901.478251] ibmveth 30000003 env3: h_multicast_ctrl rc=4 when adding an entry to the filter table ... 1718386 [ 5636.808658] ibmveth 30000003 env3: h_multicast_ctrl rc=4 when adding an entry to the filter table We got 1.5 million lines of messages in 1.3h. Let's replace netdev_err() by net_err_ratelimited() to avoid this issue. I don't use netdev_err_once() in case h_multicast_ctrl() return different lpar_rc types. Signed-off-by: Hangbin Liu <redacted> --- drivers/net/ethernet/ibm/ibmveth.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index d654c234aaf7..3b9406a4ca92 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c@@ -1446,9 +1446,11 @@ static void ibmveth_set_multicast_list(struct net_device *netdev) IbmVethMcastAddFilter, mcast_addr); if (lpar_rc != H_SUCCESS) { - netdev_err(netdev, "h_multicast_ctrl rc=%ld " - "when adding an entry to the filter " - "table\n", lpar_rc); + net_err_ratelimited("%s %s%s: h_multicast_ctrl rc=%ld when adding an entry to the filter table\n", + ibmveth_driver_name, + netdev_name(netdev), + netdev_reg_state(netdev), + lpar_rc); } }
--
2.19.2