C Chuhong Yuan #
Message details and related content
refcount_t is better for reference counters since its implementation can prevent overflows. So convert atomic_t ref counters to refcount_t. Signed-off-by: Chuhong Yuan <redacted> --- drivers/net/ethernet/chelsio/cxgb4/sched.c | 8 ++++---- drivers/net/ethernet/chelsio/cxgb4/sched.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c b/drivers/net/ethernet/chelsio/cxgb4/sched.c
index 60218dc676a8..2d04ffb31528 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c@@ -173,7 +173,7 @@ static int t4_sched_queue_unbind(struct port_info *pi, struct ch_sched_queue *p) list_del(&qe->list); kvfree(qe); - if (atomic_dec_and_test(&e->refcnt)) { + if (refcount_dec_and_test(&e->refcnt)) { e->state = SCHED_STATE_UNUSED; memset(&e->info, 0, sizeof(e->info)); }
@@ -216,7 +216,7 @@ static int t4_sched_queue_bind(struct port_info *pi, struct ch_sched_queue *p) goto out_err; list_add_tail(&qe->list, &e->queue_list); - atomic_inc(&e->refcnt); + refcount_inc(&e->refcnt); return err; out_err:
@@ -434,7 +434,7 @@ static struct sched_class *t4_sched_class_alloc(struct port_info *pi, if (err) return NULL; memcpy(&e->info, &np, sizeof(e->info)); - atomic_set(&e->refcnt, 0); + refcount_set(&e->refcnt, 0); e->state = SCHED_STATE_ACTIVE; }
@@ -488,7 +488,7 @@ struct sched_table *t4_init_sched(unsigned int sched_size) s->tab[i].idx = i; s->tab[i].state = SCHED_STATE_UNUSED; INIT_LIST_HEAD(&s->tab[i].queue_list); - atomic_set(&s->tab[i].refcnt, 0); + refcount_set(&s->tab[i].refcnt, 0); } return s; }
diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.h b/drivers/net/ethernet/chelsio/cxgb4/sched.h
index 168fb4ce3759..23a6ca1e6d3e 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sched.h
+++ b/drivers/net/ethernet/chelsio/cxgb4/sched.h@@ -69,7 +69,7 @@ struct sched_class { u8 idx; struct ch_sched_params info; struct list_head queue_list; - atomic_t refcnt; + refcount_t refcnt; }; struct sched_table { /* per port scheduling table */
--
2.20.1