On Sat, Jun 29, 2019 at 02:13:59PM +0000, linmiaohe wrote:

On 6/29/19 20:20 PM, David Ahern wrote:

quoted

On 6/28/19 8:13 PM, linmiaohe wrote:

quoted

You're right. Fib rules code would set FLOWI_FLAG_SKIP_NH_OIF flag.  
But I set it here for distinguish with the flags & XT_RPFILTER_LOOSE 
branch. Without this, they do the same work and maybe should be  
combined. I don't want to do that as that makes code confusing.
Is this code snipet below ok ? If so, I would delete this flag setting.
 
       } else if (netif_is_l3_master(dev) || netif_is_l3_slave(dev)) {
               fl6.flowi6_oif = dev->ifindex;
        } else if ((flags & XT_RPFILTER_LOOSE) == 0)
                fl6.flowi6_oif = dev->ifindex;

quoted

that looks fine to me, but it is up to Pablo.

@David Ahern  Many thanks for your valuable advice.

@ Pablo Hi, could you please tell me if this code snipet is ok?
If not, which code would you prefer? It's very nice of you to
figure it out for me. Thanks a lot.

Probably this?

        } else if (netif_is_l3_master(dev) || netif_is_l3_slave(dev) ||
                   (flags & XT_RPFILTER_LOOSE) == 0) {
                fl6.flowi6_oif = dev->ifindex;
        }

Thanks.