Thread (27 messages) flat view 27 messages, 7 authors, 2019-08-07

Re: [PATCH 03/12] block: bio_release_pages: use flags arg instead of bool

From: Christoph Hellwig <hch@infradead.org>
Date: 2019-07-24 05:31:27
Also in: ceph-devel, kvm, linux-block, linux-cifs, linux-fsdevel, linux-mm, linux-nfs, linux-rdma, lkml

On Tue, Jul 23, 2019 at 09:25:09PM -0700, john.hubbard@gmail.com wrote:
From: John Hubbard <jhubbard@nvidia.com>

In commit d241a95f3514 ("block: optionally mark pages dirty in
bio_release_pages"), new "bool mark_dirty" argument was added to
bio_release_pages.

In upcoming work, another bool argument (to indicate that the pages came
from get_user_pages) is going to be added. That's one bool too many,
because it's not desirable have calls of the form:
All pages releases by bio_release_pages should come from
get_get_user_pages, so I don't really see the point here.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help