Re: [net 1/1] tipc: fix unitilized skb list crash
From: David Miller <davem@davemloft.net>
Date: 2019-07-30 21:40:28
From: David Miller <davem@davemloft.net>
Date: 2019-07-30 21:40:28
From: Jon Maloy <redacted> Date: Tue, 30 Jul 2019 20:19:10 +0200
Our test suite somtimes provokes the following crash: Description of problem:
...
The reason is that the skb list tipc_socket::mc_method.deferredq only is initialized for connectionless sockets, while nothing stops arriving multicast messages from being filtered by connection oriented sockets, with subsequent access to the said list. We fix this by initializing the list unconditionally at socket creation. This eliminates the crash, while the message still is dropped further down in tipc_sk_filter_rcv() as it should be. Reported-by: Li Shuang <redacted> Signed-off-by: Jon Maloy <redacted>
Applied and queued up for -stable, thank you.