Re: [PATCH 1/3 net-next] linux: Add skb_frag_t page_offset accessors
From: Jakub Kicinski <hidden>
Date: 2019-07-29 21:26:11
From: Jakub Kicinski <hidden>
Date: 2019-07-29 21:26:11
On Mon, 29 Jul 2019 14:22:11 -0700, Jakub Kicinski wrote:
quoted
quoted
I realize you're following the existing code, but should we perhaps use the latest kdoc syntax? '()' after function name, and args should have '@' prefix, '%' would be for constants.That would be a task for a different cleanup. Not that I disagree with you, but there's also nothing worse than mixing styles in the same file.Funny you should say that given that (a) I'm commenting on the new code you're adding, and (b) you did do an unrelated spelling fix above ;)
Ah, sorry I misread your comment there. Some code already uses '()' in this file, as for the '%' skb_frag_ functions are the only one which have this mistake, the rest of kdoc is correct.