Re: [PATCH iproute2-next 2/3] tc: add mpls actions

On Tue, 9 Jul 2019 14:36:34 -0600
David Ahern [off-list ref] wrote:

On 7/9/19 11:00 AM, Stephen Hemminger wrote:

quoted

On Tue,  9 Jul 2019 16:59:31 +0100
John Hurley [off-list ref] wrote:
  

quoted

	if (!tb[TCA_MPLS_PARMS]) {
+		print_string(PRINT_FP, NULL, "%s", "[NULL mpls parameters]");  

This is an error message please just use fprintf(stderr instead
  

skbedit, nat as 2 examples (and the only 2 I checked) do the print_string.

Thanks I will fix those.