Re: [net-next:master 342/422] drivers/net/dsa/qca8k.c:1050:21: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_gpio_request_one'?

(let's hope that the gmail web interface doesn't mangle this too much)

On Mon, Jul 8, 2019 at 10:16 AM kbuild test robot [off-list ref] wrote:

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/davem/net-next.git master
head:   61a582be1a668a0c1407a46f779965bfeff88784
commit: a653f2f538f9d3e2d1f1445f74a47bfdace85c2e [342/422] net: dsa: qca8k: introduce reset via gpio feature
config: x86_64-randconfig-s2-07081539 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-9) 7.4.0
reproduce:
        git checkout a653f2f538f9d3e2d1f1445f74a47bfdace85c2e
        # save the attached .config to linux build tree
        make ARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All errors (new ones prefixed by >>):

   drivers/net/dsa/qca8k.c: In function 'qca8k_sw_probe':

quoted

quoted

drivers/net/dsa/qca8k.c:1050:21: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_gpio_request_one'? [-Werror=implicit-function-declaration]

     priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset",
                        ^~~~~~~~~~~~~~~~~~~~~~~
                        devm_gpio_request_one

quoted

quoted

drivers/net/dsa/qca8k.c:1051:10: error: 'GPIOD_ASIS' undeclared (first use in this function); did you mean 'GPIOF_IN'?

             GPIOD_ASIS);
             ^~~~~~~~~~
             GPIOF_IN
   drivers/net/dsa/qca8k.c:1051:10: note: each undeclared identifier is reported only once for each function it appears in

quoted

quoted

drivers/net/dsa/qca8k.c:1056:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration]

      gpiod_set_value_cansleep(priv->reset_gpio, 1);
      ^~~~~~~~~~~~~~~~~~~~~~~~
      gpio_set_value_cansleep
   cc1: some warnings being treated as errors

vim +1050 drivers/net/dsa/qca8k.c

Ok, I think that just the

#include <linux/gpio/consumer.h>

is needed. I can make a patch for this no issue. I'll download
net-next over the next days
(currently I'm just on a 3G/EDGE connection, so the 1.53 GiB will have
to wait until the
weekend.)

Regards,
Christian