On Mon,  8 Jul 2019 12:25:32 -0700, Shannon Nelson wrote:

Add a devlink interface for access to information that isn't
normally available through ethtool or the iplink interface.

Example:
	$ ./devlink -j -p dev info pci/0000:b6:00.0
	{
	    "info": {
		"pci/0000:b6:00.0": {
		    "driver": "ionic",
		    "serial_number": "FLM18420073",
		    "versions": {
			"fixed": {
			    "fw_version": "0.11.0-50",

Hm. Fixed is for hardware components. Seeing FW version reported as
fixed seems counter intuitive.  You probably want "running"?

			    "fw_status": "0x1",

I don't think this is the right interface to report status-like
information.  Perhaps devlink health reporters?

			    "fw_heartbeat": "0x716ce",

Ditto, perhaps best to report it in health stuff?

			    "asic_type": "0x0",
			    "asic_rev": "0x0"

These seem like legit "fixed" versions 👍

			}
		    }
		}
	    }
	}

Signed-off-by: Shannon Nelson <redacted>

Isn't this a new patch? Perhaps you'd be best off upstreaming the
first batch of support and add features later? It'd be easier on
reviewers so we don't have to keep re-checking the first 16 patches..