Re: [PATCH 2/3 bpf-next] i40e: Support zero-copy XDP_TX on the RX path for AF_XDP sockets.
From: Jonathan Lemon <hidden>
Date: 2019-07-02 16:31:04
On 2 Jul 2019, at 0:07, Maxim Mikityanskiy wrote:
On 2019-06-29 01:15, Jonathan Lemon wrote:quoted
+ xdpf = convert_to_xdp_frame_keep_zc(xdp); + if (unlikely(!xdpf)) + return I40E_XDP_CONSUMED; + xdpf->handle = xdp->handle;Shouldn't this line belong to convert_to_xdp_frame_keep_zc (and the previous patch)? It looks like it's code common for all drivers, and also patch 1 adds the handle field, but doesn't use it, which looks weird.
Good point. I'll move it into the function. -- Jonathan