Thread (7 messages) 7 messages, 4 authors, 2019-07-01

RE: [PATCH net-next 0/2] net: ipv4: fix circular-list infinite loop

From: Ran Rozenstein <hidden>
Date: 2019-07-01 06:46:36

-----Original Message-----
From: Tariq Toukan
Sent: Sunday, June 30, 2019 10:57
To: David Miller <davem@davemloft.net>; fw@strlen.de
Cc: netdev@vger.kernel.org; Ran Rozenstein <redacted>; Tariq
Toukan [off-list ref]
Subject: Re: [PATCH net-next 0/2] net: ipv4: fix circular-list infinite loop



On 6/27/2019 7:54 PM, David Miller wrote:
quoted
From: Florian Westphal <fw@strlen.de>
Date: Thu, 27 Jun 2019 14:03:31 +0200
quoted
Tariq and Ran reported a regression caused by net-next commit
2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list").

This happens when net.ipv4.conf.$dev.promote_secondaries sysctl is
enabled -- we can arrange for ifa->next to point at ifa, so next
process that tries to walk the list loops forever.

Fix this and extend rtnetlink.sh with a small test case for this.
Series applied, thanks Florian.
Thanks Florian!

Ran, please test and update.

Tariq
Thanks Florian.
Didn't reproduce tonight with the fixes.

Ran.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help