Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift
From: David Miller <davem@davemloft.net>
Date: 2019-06-27 17:34:27
Also in:
linux-kernel-mentees, lkml
From: David Miller <davem@davemloft.net>
Date: 2019-06-27 17:34:27
Also in:
linux-kernel-mentees, lkml
From: Jiunn Chang <redacted> Date: Thu, 27 Jun 2019 11:57:28 -0500
On Thu, Jun 27, 2019 at 09:22:53AM -0700, David Miller wrote:quoted
From: Shuah Khan <skhan@linuxfoundation.org> Date: Wed, 26 Jun 2019 21:32:52 -0600quoted
On 6/26/19 9:25 PM, Jiunn Chang wrote:quoted
Shifting signed 32-bit value by 31 bits is undefined. Changing most significant bit to unsigned. Changes included in v2: - use subsystem specific subject lines - CC required mailing listsThese version change lines don't belong in the change log.For networking changes I actually like the change lines to be in the commit log. So please don't stray people this way, thanks.Hello David, Would you like me to send v3 with the change log in the patch description?
I'll use v2 which had this done correctly.