Thread (2 messages) flat view 2 messages, 2 authors, 2019-06-17

Re: [PATCH] uapi: avoid namespace conflict in linux/posix_types.h

From: Florian Weimer <hidden>
Date: 2019-06-17 18:19:55
Also in: linux-api, linux-arch, lkml

* Linus Torvalds:
On Mon, Jun 17, 2019 at 11:03 AM Florian Weimer [off-list ref] wrote:
quoted
There's also __kernel_fd_set in <linux/posix_types.h>.  I may have
lumped this up with <asm/posix_types.h>, but it has the same problem.
Hmm.

That one we might be able to just fix by renaming "fds_bits" to "__fds_bits".

Unlike the "val[]" thing, I don't think anybody is supposed to access
those fields directly.
Well, glibc already calls it __val …
I think fd_set and friends are now supposed to be in <sys/select.h>
anyway, and the "it was in <sys/types.h>" is all legacy.
Do you suggest to create a <linux/select.h> header to mirror this?

Thanks,
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help